PWGHF: First version of the Bs creator, selector, task by pchrista · Pull Request #312 · AliceO2Group/O2Physics

pchrista · 2021-11-22T08:15:44Z

No description provided.

fcolamar

Hi Panos, as a preliminary comment, let me signal that by using the doMC option approach to select the tasks to be run, it won't be possible to switch off the MC task for the HFCandidateCreatorBs and the taskBs when running on Hyperloop. This because such global options cannot be set in Hyperloop, and the defaults value 'true' will be considered.
In case you plan to run on Hyperloop and to switch off the MC tasks at some point, I would suggest to modify those codes structure moving to a single task with two processes, activated/deactivated via a PROCESS_SWITCH (that can be set as a standard configurable), look e.g. at #230 or #231

fcolamar

Hi Panos, I added some comments related to the taskBs.cc, cheers!

fcolamar · 2021-11-24T09:55:49Z

+
+  void init(o2::framework::InitContext&)
+  {
+    registry.add("hEtaGen", "MC particles (matched);#Lambda_{b}^{0} candidate #it{#eta}^{gen};entries", {HistType::kTH2F, {{100, -2., 2.}, {(std::vector<double>)bins, "#it{p}_{T} (GeV/#it{c})"}}});


Same comments as for the other task about histogram names and definition of a vector for setting the histogram bins

vkucera · 2021-11-24T11:30:44Z

Hi @pchrista , please fix the compilation warning.

vkucera · 2021-11-24T11:42:32Z

+    // check that the candidate pT is within the analysis range
+    if (candpT < pTCandMin || candpT >= pTCandMax) {
+      return false;
+    }
+


I am sorry, this should not have been removed. I thought it was checking the selector array pT range, but it actually checks a configurable range.

vkucera · 2021-11-24T12:00:30Z

+        // Match Ds+ -> φπ -> K+K-π
+        auto DsCandMC = particlesMC.iteratorAt(particle.daughter0Id());


Use particle.daughter0_as instead.

pchrista · 2021-11-25T22:14:33Z

Hi @fcolamar @vkucera could you check and let me know what I missed?

fcolamar · 2021-11-26T10:45:58Z

Hi @pchrista, in the latest version of the taskBs I still see the pdg::Code::kLambdaB0 calls at L192 and L241, and two Lambda_c labels at L58 and L61.
For the rest instead the taskBs.cxx looks fine to me.

pchrista · 2021-11-30T10:46:27Z

Thanks @fcolamar and apologies for the delay and the omission; I just pushed some changes

fcolamar · 2021-12-01T09:45:48Z

Hi Panos, ok for the taskBs from my side, but of course let's see whether Vit has still comments on the other files

pchrista · 2021-12-08T09:21:21Z

hi @vkucera , could you give it a look? It would be great if this code is merged so that Maurice can pick it up and develop/improve it further

vkucera · 2021-12-09T02:17:18Z

+// specific Bs candidate properties
+namespace hf_cand_bs
+{
+DECLARE_SOA_INDEX_COLUMN_FULL(Index0, index0, int, HfCandProng3, "_0"); // Bs index


Suggested change

DECLARE_SOA_INDEX_COLUMN_FULL(Index0, index0, int, HfCandProng3, "_0"); // Bs index

DECLARE_SOA_INDEX_COLUMN_FULL(Index0, index0, int, HfCandProng3, "_0"); // Ds index

vkucera · 2021-12-09T02:17:48Z

+DECLARE_SOA_COLUMN(OriginMCRec, originMCRec, int8_t);       // particle origin, reconstruction level
+DECLARE_SOA_COLUMN(OriginMCGen, originMCGen, int8_t);       // particle origin, generator level


Are these needed?

vkucera · 2021-12-09T02:18:08Z

+enum DecayType { BsToDsPi }; // move this to a dedicated cascade namespace in the future?
+
+// Bs → Ds+ π- → K+ K- π+ π-
+// float massBs = RecoDecay::getMassPDG(pdg::Code::kBs);


Suggested change

// float massBs = RecoDecay::getMassPDG(pdg::Code::kBs);

vkucera · 2021-12-09T02:18:33Z

+}
+template <typename T>


Suggested change

}

template <typename T>

}

template <typename T>

vkucera · 2021-12-09T02:22:58Z

+        auto errorDecayLength = std::sqrt(getRotatedCovMatrixXX(covMatrixPV, phi, theta) + getRotatedCovMatrixXX(covMatrixPCA, phi, theta));
+        auto errorDecayLengthXY = std::sqrt(getRotatedCovMatrixXX(covMatrixPV, phi, 0.) + getRotatedCovMatrixXX(covMatrixPCA, phi, 0.));
+
+        int hfFlag = 1 << hf_cand_bs::DecayType::BsToDsPi;


How is this flag useful?

vkucera · 2021-12-09T02:29:56Z

+      origin = 0;
+      // Bs → Ds+ π-
+      if (RecoDecay::isMatchedMCGen(particlesMC, particle, pdg::Code::kBs, array{int(pdg::Code::kDs), -kPiPlus}, true)) {
+        // Match Ds+ -> φπ -> K+K-π


How is this related to φπ?

vkucera · 2021-12-09T02:30:26Z

+    adaptAnalysisTask<HFCandidateCreatorBsExpressions>(cfgc, TaskName{"hf-cand-creator-bs-expressions"})};
+  const bool doMC = cfgc.options().get<bool>("doMC");
+  if (doMC) {
+    workflow.push_back(adaptAnalysisTask<HFCandidateCreatorBsMC>(cfgc, TaskName{"hf-cand-creator-bs-mc"}));


Do not use TaskName.

vkucera · 2021-12-09T02:32:50Z

+        // Bs → Ds+ π-
+        // Printf("Checking Bs → Ds+ π-");


Here you seem to be checking the Ds decay.

vkucera · 2021-12-09T02:34:55Z

+          flag = 1 << hf_cand_bs::DecayType::BsToDsPi;
+        } else {
+          debug = 1;
+          LOGF(info, "WARNING: Λb in decays in the expected final state but the condition on the intermediate state is not fulfilled");


Is this an info or a warning?
What do you want to report here?

vkucera · 2021-12-09T02:40:25Z

+        if (trackPion.sign() > 0) {
+          continue;
+        }


What is the purpose of this cut?

vkucera · 2021-12-11T00:50:43Z

+
+#include "Framework/runDataProcessing.h"
+
+/// Reconstruction of Λb candidates


vkucera · 2021-12-11T00:51:02Z

+
+#include "Framework/runDataProcessing.h"
+
+/// Λb0 analysis task


github-actions · 2022-01-20T01:18:08Z

This PR has not been updated in the last 30 days. Is it still needed? Unless further action is taken, it will be closed in 5 days.

* PWGLF: physical primary checks for h-Str analysis * Add physical primary condition also for closure * Please consider the following formatting changes (#312) * Please consider the following formatting changes (#313) --------- Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>

* PWGLF: physical primary checks for h-Str analysis * Add physical primary condition also for closure * Please consider the following formatting changes (AliceO2Group#312) * Please consider the following formatting changes (AliceO2Group#313) --------- Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>

pchrista requested review from alibuild, fcolamar, ginnocen and vkucera as code owners November 22, 2021 08:15

vkucera marked this pull request as draft November 22, 2021 16:28

pchrista force-pushed the master branch 3 times, most recently from ccaaec5 to cd46ded Compare November 23, 2021 14:29

fcolamar reviewed Nov 23, 2021

View reviewed changes

pchrista marked this pull request as ready for review November 23, 2021 15:57

pchrista force-pushed the master branch from cd46ded to 243e788 Compare November 24, 2021 08:41

fcolamar requested changes Nov 24, 2021

View reviewed changes

vkucera marked this pull request as draft November 24, 2021 10:19

vkucera requested changes Nov 24, 2021

View reviewed changes

pchrista force-pushed the master branch from 1704480 to 3605f6e Compare November 25, 2021 22:10

vkucera requested changes Dec 9, 2021

View reviewed changes

vkucera changed the title ~~PWGHF: First version of the Bs creator~~ PWGHF: First version of the Bs creator, selector, task Dec 11, 2021

vkucera requested changes Dec 11, 2021

View reviewed changes

pchrista added 6 commits December 20, 2021 10:22

First version of the Bs creator

1892bca

Format/clang changes

4c26bce

Adding the first version of the Bs task

48ffc4f

Add the Bs selector

e26f761

test for copyright

1614289

Modifications based on comments

0ff45a2

pchrista added 2 commits December 20, 2021 10:22

Format changes

f7ea2c4

Naming changes Bs instead of Lb

ceddbaf

pchrista force-pushed the master branch from fd9f892 to ceddbaf Compare December 20, 2021 09:24

github-actions Bot added the stale label Jan 20, 2022

github-actions Bot closed this Jan 26, 2022

alibuild added a commit to alibuild/O2Physics that referenced this pull request Jul 30, 2024

Please consider the following formatting changes (AliceO2Group#312)

642b1d5

		// Match Ds+ -> φπ -> K+K-π
		auto DsCandMC = particlesMC.iteratorAt(particle.daughter0Id());

	DECLARE_SOA_INDEX_COLUMN_FULL(Index0, index0, int, HfCandProng3, "_0"); // Bs index
	DECLARE_SOA_INDEX_COLUMN_FULL(Index0, index0, int, HfCandProng3, "_0"); // Ds index

		DECLARE_SOA_COLUMN(OriginMCRec, originMCRec, int8_t); // particle origin, reconstruction level
		DECLARE_SOA_COLUMN(OriginMCGen, originMCGen, int8_t); // particle origin, generator level


		#include "Framework/runDataProcessing.h"

		/// Reconstruction of Λb candidates


		#include "Framework/runDataProcessing.h"

		/// Λb0 analysis task

Conversation

pchrista commented Nov 22, 2021

Uh oh!

fcolamar left a comment

Choose a reason for hiding this comment

Uh oh!

fcolamar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

vkucera commented Nov 24, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pchrista commented Nov 25, 2021

Uh oh!

fcolamar commented Nov 26, 2021

Uh oh!

pchrista commented Nov 30, 2021

Uh oh!

fcolamar commented Dec 1, 2021

Uh oh!

pchrista commented Dec 8, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jan 20, 2022

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants